Neverwinter Nights: GetGoldPieceValue() Does it work correctly?

Games

Support

Forums

BioWare Info

My Account

Community Sign Up

Store

Home Forum Index Neverwinter Nights 2 NWN2: Builders - NWN2 Scripting GetGoldPieceValue() Does it work correctly?

NWN2: Builders - NWN2 Scripting

Add this To My Topics

Go To Bottom

Author	GetGoldPieceValue() Does it work correctly?
cdaulepp Game Owner NWN NWN: SoU NWN: HotU NWN 2 NWN 2: MotB Joined: 10 Aug 2003	Posted: Monday, 07 April 2008 10:48PM
	I am dynamically creating a "lens of detection" item on a monster. When I use the function GetGoldPieceValue to check the item's value, it is returning "1" instead of the 12K gold piece value that the item actually has. Anyone have any idea why this is? Does it have anything to do with the item being dynamically created? Does it have anything to do with the lens of detection being a miscellaneous small category of item? I can't figure out why, but when I get the value it definitely returns 1 GP. The function GetGoldPieceValue seems to be working properly. Other item values are returned properly. But it seems that miscellaneous musical instruments seem to have problems. I have no clue why. cdaulepp _________________ Download my random loot generator: VERSION 2.0 BETA Click Here

loudent2 Game Owner NWN NWN: SoU SW: KotOR Xbox Jade Empire NWN 2 NWN 2: MotB NWN 2: SoZ Joined: 11 Feb 2003	Posted: Monday, 07 April 2008 11:07PM
	I suppose the first question is whether or not the item is identified and if that makes a difference. _________________ Lost Dungeons of Adventure - NWN2 Action PW

cdaulepp Game Owner NWN NWN: SoU NWN: HotU NWN 2 NWN 2: MotB Joined: 10 Aug 2003	Posted: Tuesday, 08 April 2008 01:29AM
	Quote: Posted 04/07/08 23:07 (GMT) by loudent2 I suppose the first question is whether or not the item is identified and if that makes a difference. Thank you. You were exactly right and I appreciate the diplomatic way you handled that. I totally wasn't thinking about whether the item is identified or not. That solved a logical error in my programming I have missed for the better part of a year. Thanks, cdaulepp _________________ Download my random loot generator: VERSION 2.0 BETA Click Here

cdaulepp Game Owner NWN NWN: SoU NWN: HotU NWN 2 NWN 2: MotB Joined: 10 Aug 2003	Posted: Tuesday, 08 April 2008 04:53PM
	Here is something that will help (this post is off topic a little) In the file "fw_random_loot" you will want to add some code to the function "FW_CreateLootOnObject". The part you want to add is near the bottom of that function. I had DestroyObject in the "if" clause, but I needed to have the same in the "else" clause and it is not currently there. In the "else" clause I added the line: DestroyObject (strStruct.oItem); to fix the problem. This is necessary to make sure the overly expensive item is destroyed before creating gold on the spawning monster. Another piece of code is required to make the correction complete. Explained below. NWScript: // Now that we have an item chosen, if overall gold piece restrictions // are turned on, then this section makes sure the item isn't too valuable // for the CR of the monster. if ((FW_ALLOW_OVERALL_GP_RESTRICTIONS) && (FW_IsItemRolledTooExpensive(strStruct.oItem, nCR))) { if (nNumReRolls > 0) { // Destroy the item that is too valuable. DestroyObject (strStruct.oItem); nNumReRolls--; // Pick a new item strStruct = FW_CreateLootOnObject (strStruct, nCR, nNumReRolls); } // When we've rerolled 10 times but we still haven't found acceptable // treasure yet, we default to gold. I also have to let the random // loot generator know I switched loot type categories. else // nNumReRolls <= 0 { DestroyObject (strStruct.oItem); strStruct.nLootType = FW_MISC_GOLD; strStruct.oItem = FW_Get_Random_Gold (); } } // end of if View Post/Code in separate window After you have added the DestroyObject line of code above you will need to open the script "fw_inc_item_value_restrictions" and navigate to the function implementation of the function "FW_IsItemRolledTooExpensive". That is the very last function in that script file. You will need to add a line that sets the item to identified, as shown below. You must place the line identifying the object before you get the gold piece value, so order is important. NWScript: int FW_IsItemRolledTooExpensive (object oItem, int nCR = 0) { // Here is the new line to fix GP restrictions. SetIdentified (oItem, TRUE); int nMaxItemValue = FW_GetMaxItemValue(nCR); int nItemGPValue = GetGoldPieceValue (oItem); if (nItemGPValue > nMaxItemValue) { return TRUE; } return FALSE; View Post/Code in separate window This will fix the problem of miscellaneous (or any other item for that matter) of appearing on a monster that is over the GP limit you set. P.S. Don't worry, the main program currently sets all spawning items to UN-identified right before exiting. So identifying the item here won't leave it identified. It gets changed back to unidentified later in another section of the code. For anyone else reading this, you are probably wondering what I am talking about. Don't worry about it. I am posting a quickfix for a friend so he/she can do a hotfix until I release the next version of my random loot generator. cdaulepp _________________ Download my random loot generator: VERSION 2.0 BETA Click Here Edited By cdaulepp on 04/08/08 16:57

Wyvern76 Game Owner NWN NWN: SoU NWN: HotU NWN 2 NWN 2: MotB NWN 2: SoZ Mass Effect PC Joined: 10 Aug 2002	Posted: Tuesday, 08 April 2008 07:55PM
	Thanks a bunch! I will try to paste this in tonight or tomorrow. Damn work......wish I had time right now. The Staff was really flipping out about the 20k items being dropped from Kobolds in our low wealth PW. Thanks again for the quick solution. _________________ Staff: Obsidian Shore a welcoming RP persistant World Click Here

Vendalus Game Owner NWN NWN: SoU NWN: HotU NWN 2 NWN 2: MotB Joined: 30 Jun 2002	Posted: Wednesday, 09 April 2008 01:26PM
	cdaulepp, can you post your final code for getting values? I'm curious to see the logic you used to handle the identification issue. Thanks! _________________ Vendalus' Corner Wendersnaven.com Vault Submissions

cdaulepp Game Owner NWN NWN: SoU NWN: HotU NWN 2 NWN 2: MotB Joined: 10 Aug 2003	Posted: Wednesday, 09 April 2008 05:39PM
	Quote: Posted 04/09/08 13:26 (GMT) by Vendalus cdaulepp, can you post your final code for getting values? I'm curious to see the logic you used to handle the identification issue. Thanks! I guess so. Here is what I have now. But this may change as I continue updating the random loot generator. The first code is from the script file "fw_random_loot" and the posted function picks a loot category for the treasure. Then a gold piece value check is performed to make sure the item is not too expensive. If it is too expensive, I reroll (up to 10 times). If, after 10 rolls, the item chosen is still too expensive, I default back to creating gold on the monster instead of an item. NWScript: ////////////////////////////////////////// // * This function returns the generic loot struct we're going to add // * item property(s) to. By default any type of loot can drop. This // * function (as of version 1.1) now checks for race specific loot drops // * when the switch for race specific loot drops is set. // struct MyStruct FW_CreateLootOnObject(struct MyStruct strStruct, int nCR = 0, int nNumReRolls = 10) { int nRoll; int nMaterial; // Check to see if we're doing race specific loot drops. if (FW_RACE_SPECIFIC_LOOT_DROPS == TRUE) { strStruct.nLootType = FW_Get_Racial_Loot_Category (); } // Otherwise, we don't care what race the monster is, just drop // anything! That's what the else does. else { strStruct.nLootType = FW_Get_Default_Loot_Category (); } switch (strStruct.nLootType) { case FW_ARMOR_BOOT: { strStruct.oItem = CreateItemOnObject ("fw_itm_armor_generic_boot"); } break; case FW_ARMOR_CLOTHING:{ strStruct.oItem = CreateItemOnObject ("fw_itm_armor_generic_clothes"); } break; case FW_ARMOR_HEAVY: nRoll = Random (3); // 0 = Banded, 1 = HalfPlate, 2 = FullPlate if (nRoll == 0) { strStruct.oItem = FW_Get_Random_Metal_Armor (FW_ARMOR_HEAVY_BANDED); } else if (nRoll == 1) { strStruct.oItem = FW_Get_Random_Metal_Armor (FW_ARMOR_HEAVY_HALFPLATE); } else /* (nRoll == 2)/{ strStruct.oItem = FW_Get_Random_Metal_Armor (FW_ARMOR_HEAVY_FULLPLATE); } break; case FW_ARMOR_HELMET: { strStruct.oItem = CreateItemOnObject ("fw_itm_armor_generic_helmet"); } break; case FW_ARMOR_LIGHT: nRoll = Random (4); // 0 = Padded, 1 = Leather, 2 = Studded Leather, 3 = Chain Shirt if (nRoll == 0) { strStruct.oItem = CreateItemOnObject ("fw_itm_armor_generic_padded"); } else if (nRoll == 1) { strStruct.oItem = CreateItemOnObject ("fw_itm_armor_generic_leather"); } else if (nRoll == 2) { strStruct.oItem = CreateItemOnObject ("fw_itm_armor_generic_studded"); } else / (nRoll == 3)/{ strStruct.oItem = FW_Get_Random_Metal_Armor (FW_ARMOR_LIGHT_CHAINSHIRT); } break; case FW_ARMOR_MEDIUM: nRoll = Random (4); // 0 = Hide, 1 = ScaleMail, 2 = ChainMail, 3 = Breastplate if (nRoll == 0) { strStruct.oItem = CreateItemOnObject ("fw_itm_armor_generic_hide"); } else if (nRoll == 1) { strStruct.oItem = FW_Get_Random_Metal_Armor (FW_ARMOR_MEDIUM_SCALEMAIL); } else if (nRoll == 2) { strStruct.oItem = FW_Get_Random_Metal_Armor (FW_ARMOR_MEDIUM_CHAINMAIL); } else / (nRoll == 3)/{ strStruct.oItem = FW_Get_Random_Metal_Armor (FW_ARMOR_MEDIUM_BREASTPLATE);} break; case FW_ARMOR_SHIELDS: nRoll = Random (3); // 0 = Light, 1 = Heavy, 2 = Tower if (nRoll == 0) { strStruct.oItem = CreateItemOnObject ("fw_itm_armor_shield_generic_ligh"); } else if (nRoll == 1) { strStruct.oItem = CreateItemOnObject ("fw_itm_armor_shield_generic_heav"); } else { strStruct.oItem = CreateItemOnObject ("fw_itm_armor_shield_generic_towe"); } break; case FW_WEAPON_AMMUNITION: nRoll = Random (3); // 0 = Arrow, 1 = Bolt, 2 = Bullet if (nRoll == 0) { strStruct.oItem = CreateItemOnObject ("nw_wamar001", OBJECT_SELF, 99); } else if (nRoll == 1) { strStruct.oItem = CreateItemOnObject ("nw_wambo001", OBJECT_SELF, 99); } else / (nRoll == 2)/{ strStruct.oItem = CreateItemOnObject ("nw_wambu001", OBJECT_SELF, 99); } break; case FW_WEAPON_SIMPLE: { strStruct.oItem = FW_Get_Random_Weapon_Simple (); } break; case FW_WEAPON_MARTIAL: { strStruct.oItem = FW_Get_Random_Weapon_Martial (); } break; case FW_WEAPON_EXOTIC: { strStruct.oItem = FW_Get_Random_Weapon_Exotic (); } break; case FW_WEAPON_MAGE_SPECIFIC: nRoll = Random (3); // 0 = Rod, 1 = Staff, 2 = Wand if (nRoll == 0) { strStruct.oItem = CreateItemOnObject ("fw_itm_weap_generic_rod"); FW_Get_Random_Wand (strStruct); } else if (nRoll == 1) { strStruct.oItem = CreateItemOnObject ("fw_itm_weap_generic_staff"); } else / (nRoll == 2)/{ strStruct.oItem = CreateItemOnObject ("fw_itm_weap_generic_wand"); FW_Get_Random_Wand (strStruct); } break; case FW_WEAPON_RANGED: { strStruct.oItem = FW_Get_Random_Weapon_Ranged (); } break; case FW_WEAPON_THROWN: nRoll = Random (3); // 0 = Throwing Axe, 1 = Dart, 2 = Shuriken if (nRoll == 0) { strStruct.oItem = CreateItemOnObject ("nw_wthax001", OBJECT_SELF, 50); } else if (nRoll == 1) { strStruct.oItem = CreateItemOnObject ("nw_wthdt001", OBJECT_SELF, 50); } else / (nRoll == 2)/{ strStruct.oItem = CreateItemOnObject ("nw_wthsh001", OBJECT_SELF, 50); } break; case FW_MISC_CLOTHING: nRoll = Random (4); // 0 = Belt, 1 = Boot, 2 = Bracer, 3 = Cloak if (nRoll == 0) { strStruct.oItem = CreateItemOnObject ("fw_itm_misc_generic_belt"); } else if (nRoll == 1) { strStruct.oItem = CreateItemOnObject ("fw_itm_misc_generic_boot"); } else if (nRoll == 2) { strStruct.oItem = CreateItemOnObject ("fw_itm_misc_generic_bracer"); } else / (nRoll ==3 )/{ strStruct.oItem = CreateItemOnObject ("fw_itm_misc_generic_cloak"); } break; case FW_MISC_JEWELRY: nRoll = Random (2); // 0 = Amulet, 1 = Ring if (nRoll == 0) { strStruct.oItem = CreateItemOnObject ("fw_itm_misc_generic_amulet"); } else / (nRoll == 1)/{ strStruct.oItem = CreateItemOnObject ("fw_itm_misc_generic_ring"); } break; case FW_MISC_GAUNTLET: { strStruct.oItem = CreateItemOnObject ("fw_itm_misc_generic_gauntlet"); } break; case FW_MISC_POTION: { strStruct.oItem = FW_Get_Random_Potion (strStruct); } break; case FW_MISC_TRAPS: { strStruct.oItem = FW_Get_Random_Trap (strStruct, nCR); } break; case FW_MISC_BOOKS: { strStruct.oItem = FW_Get_Random_Book (strStruct); } break; case FW_MISC_GOLD: { strStruct.oItem = FW_Get_Random_Gold (); } break; case FW_MISC_GEMS: { strStruct.oItem = FW_Get_Random_Gem (strStruct); } break; case FW_MISC_HEAL_KIT: { strStruct.oItem = FW_Get_Random_Heal_Kit (strStruct); } break; case FW_MISC_SCROLL: { strStruct.oItem = FW_Get_Random_Scroll (strStruct); } break; case FW_MISC_CRAFTING_MATERIAL: { strStruct.oItem = FW_Get_Random_Crafting_Material (strStruct); } break; case FW_MISC_OTHER: { strStruct.oItem = FW_Get_Random_Misc_Other (strStruct); } break; case FW_MISC_DAMAGE_SHIELD: { strStruct.oItem = FW_Get_Random_Misc_Damage_Shield_Item (strStruct); } break; case FW_MISC_CUSTOM_ITEM: { strStruct.oItem = FW_Get_Random_Misc_Custom_Item (strStruct); } break; // It's always safe to add gold, so that's default default: { strStruct.oItem = FW_Get_Random_Gold (); } break; } // end of switch // Now that we have an item chosen, if overall gold piece restrictions // are turned on, then this section makes sure the item isn't too valuable // for the CR of the monster. if ((FW_ALLOW_OVERALL_GP_RESTRICTIONS) && (FW_IsItemRolledTooExpensive(strStruct.oItem, nCR))) { if (nNumReRolls > 0) { // Destroy the item that is too valuable. DestroyObject (strStruct.oItem); nNumReRolls--; // Pick a new item strStruct = FW_CreateLootOnObject (strStruct, nCR, nNumReRolls); } // When we've rerolled 10 times but we still haven't found acceptable // treasure yet, we default to gold. I also have to let the random // loot generator know I switched loot type categories. else // nNumReRolls <= 0 { DestroyObject (strStruct.oItem); strStruct.nLootType = FW_MISC_GOLD; strStruct.oItem = FW_Get_Random_Gold (); } } // end of if return strStruct; } // end of function View Post/Code in separate window The next posted section of code is the function "FW_IsItemRolledTooExpensive" in the script file "fw_inc_item_value_restrictions." This function does a simple check to see if the item is too high value or not. I identify the item first because unidentified items return a value = 1GP, even if they are really worth a lot more than that. (Later on in my system, I change the item back to unidentified) NWScript: ////////////////////////////////////////////// // This function checks to see if the item chosen by the random // * loot generator is less than the allowable GP limit for the // * spawning monster. If the Item is too expensive for the CR of // * the monster, then this returns TRUE (and the loot generator // * will reroll a new item). If the item is within appropriate // * GP limits then this returns FALSE. // int FW_IsItemRolledTooExpensive (object oItem, int nCR = 0) { SetIdentified (oItem, TRUE); int nMaxItemValue = FW_GetMaxItemValue(nCR); int nItemGPValue = GetGoldPieceValue (oItem); if (nItemGPValue > nMaxItemValue) { return TRUE; } return FALSE; } View Post/Code in separate window Basically, to fix the error of unidentified items showing up as loot I had to add two lines of code. In the first section above, I added a "DestroyObject" line of code to the "else" statment towards the very end of that section of code. The second line I added was the "SetIdentified" line in the second section of code I posted. That takes care of the problems. Of course, this code relies on a bunch of datatypes and variables that are defined elsewhere throughout my system, but the basic logic is there so you can examine it. cdaulepp _________________ Download my random loot generator: VERSION 2.0 BETA Click Here

cdaulepp Game Owner NWN NWN: SoU NWN: HotU NWN 2 NWN 2: MotB Joined: 10 Aug 2003	Posted: Wednesday, 09 April 2008 05:42PM
	The actual final code may look different for the version 2.0 update. I don't anticipate finishing that until after my finals for second semester of law school are done. cdaulepp _________________ Download my random loot generator: VERSION 2.0 BETA Click Here

CID-78 Game Owner NWN NWN: SoU NWN: HotU SW: KotOR PC Jade Empire:SE NWN 2 NWN 2: MotB NWN 2: SoZ Joined: 01 Oct 2002 From: Landskrona, Sweden	Posted: Thursday, 10 April 2008 10:35AM
	why don't you calculate the itemcost before applying the on the fly enchantments. and the basecost can be excluded from the random roll, if they cost more then max amount. that would be how i would do it, haven't bothered to check your code. but rerolling is a waste of resources. _________________ Community Representant - NWN2 Toolset Forum

Wyvern76 Game Owner NWN NWN: SoU NWN: HotU NWN 2 NWN 2: MotB NWN 2: SoZ Mass Effect PC Joined: 10 Aug 2002	Posted: Sunday, 20 April 2008 07:57PM
	Finally found time to put this fix in. Thank you again! And I look forward to the next version of your loot generator. Keep up the good work! _________________ Staff: Obsidian Shore a welcoming RP persistant World Click Here

Home Forum Index Neverwinter Nights 2 NWN2: Builders - NWN2 Scripting GetGoldPieceValue() Does it work correctly?

What do these icons mean?
Where can I learn how to use the forums?

Jump To:

Search Forums | Forums FAQ | Forum Archives

NeverWinter Nights 2, Forgotten Realms and the Forgotten Realms logo, Dungeons & Dragons, D&D, and the Dungeons & Dragons logo, and Wizards of the Coast and its logo are trademarks of Wizards of the Coast, Inc., in the U.S.A. and other countries, and are used with permission. © 2004 Wizards. Software © 2004 Atari Interactive, Inc. All rights reserved. HASBRO and its logo are trademarks of Hasbro and are used with permission. Windows is either a registered trademark or trademark of Microsoft Corporation in the United States and/or other countries. Manufactured and marketed by Atari, Inc., New York, NY. All other trademarks are the property of their respective owners.

Powered by BioBoards Version 3.00.0 10.1.12.31

Web Site Help
Jobs | Website Terms of Use Agreement | Privacy Policy
Rules of Conduct | Copyright and Trademark Information

	6,251,297 Users 170 Online 11 Logged In 9,046,484 posts in forums Newest Forum Topics: 1. These forums are now closed (NWN 1: Scripting) 2. These forums are now closed (NWN2: Guilds and Registry) 3. These forums are now closed (BioWare News Discussion) 4. Can you level items? (NWN 1: Scripting) 5. Thank you! (NWN 1: Scripting) Current time is: (set time) Fri, 03 September 2010 12:57AM